Add symlinks to qvm-device #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For this to work, there needs to be a similar PR removing qvm-device symlinks from core-admin, otherwise packages will conflict. |
|
What about package upgrades? |
|
It will require appropriate dependencies for clean upgrades. I'll add them after merging. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #269 +/- ##
=======================================
Coverage 75.24% 75.24%
=======================================
Files 52 52
Lines 8975 8975
=======================================
Hits 6753 6753
Misses 2222 2222 ☔ View full report in Codecov by Sentry. |
DemiMarie
added a commit
to DemiMarie/qubes-core-admin
that referenced
this pull request
Jan 5, 2024
They are being moved to qubes-core-admin-client (QubesOS/qubes-core-admin-client#269).
DemiMarie
added a commit
to DemiMarie/qubes-core-admin
that referenced
this pull request
Jan 6, 2024
They are being moved to qubes-core-admin-client (QubesOS/qubes-core-admin-client#269).
13 tasks
DemiMarie
added a commit
to DemiMarie/qubes-core-admin
that referenced
this pull request
Nov 14, 2024
They are being moved to qubes-core-admin-client (QubesOS/qubes-core-admin-client#269).
marmarek
requested changes
Jan 6, 2025
Interestingly, rpm is happy with two packages owning the same file - I guess it works because the file is exactly the same. |
These were only in dom0, which is inconsistent. Fixes: QubesOS/qubes-issues#8786
DemiMarie
force-pushed
the
add-device-symlinks
branch
from
a88c03d to
9d3a7a1
Compare
marmarek
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were only in dom0, which is inconsistent.
Fixes: QubesOS/qubes-issues#8786